Rewrite program cache #6608
Closed
Rewrite program cache #6608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripatel-fd
force-pushed
the
ripatel/program-cache-sep
branch
6 times, most recently
from
8ebeca0 to
375b575
Compare
ripatel-fd
force-pushed
the
ripatel/program-cache-sep
branch
5 times, most recently
from
b7e34a7 to
dce26c1
Compare
mjain-jump
reviewed
Oct 6, 2025
ripatel-fd
force-pushed
the
ripatel/program-cache-sep
branch
from
dce26c1 to
805f08a
Compare
ripatel-fd
force-pushed
the
ripatel/program-cache-sep
branch
5 times, most recently
from
62f8e14 to
5ee2476
Compare
mmcgee-jump
reviewed
Oct 7, 2025
| program_id, | ||
| &cache_entry )!=0 ) ) { | ||
| /* https://github.com/anza-xyz/agave/blob/v2.2.6/programs/loader-v4/src/lib.rs#L522-L528 */ | ||
| fd_progcache_rec_t const * cache_entry = |
There was a problem hiding this comment.
Isn't this a concurrent access? The entry might get evicted before you can read executable etc
There was a problem hiding this comment.
I will fix this in a follow-up PR. The purpose of this PR was to separate out the account database and the loaded program cache.
ripatel-fd
force-pushed
the
ripatel/program-cache-sep
branch
3 times, most recently
from
bf29fd5 to
2e58ab1
Compare
- Reduce funk key size to 32 bytes (from 40 bytes)
- Move program cache to separate funk instance and wksp
- Introduce program cache eviction policy
- Restructure program cache logic / general cleanup
- Reduce verbosity in API documentation
- Clean up API naming
- Split up API into a few smaller headers
- Reduce program cache fill allocations and memory copies
(directly populate calldests map, skip calldests map alloc for
newer sBPF versions)
- Remove broken/unused concurrency model in previous program cache
implementation
- Remove strict instruction logging requirements
(no program cache tombstone entries for obviously invalid
programs, such as invalid section table)
- Simplify cache invalidation logic ("queue program for re-
verification"): now just inserts a tombstone
- Reuse cache entries across forks (cache entries tracked at fork
graph nodes determined by program modify slot, instead of program
load slot)
ripatel-fd
force-pushed
the
ripatel/program-cache-sep
branch
from
2e58ab1 to
1d05b87
Compare
Performance Measurements ⏳
|
|
Changes are included in #6653 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(directly populate calldests map, skip calldests map alloc for
newer sBPF versions)
implementation